Skip to content

Dockerized FSCT project#13

Open
semocodev wants to merge 5 commits into
SKrisanski:mainfrom
semocodev:feat/refactor
Open

Dockerized FSCT project#13
semocodev wants to merge 5 commits into
SKrisanski:mainfrom
semocodev:feat/refactor

Conversation

@semocodev

Copy link
Copy Markdown

Main changes:

  • Main file added to invoke code from project root path. Python arguments refactored.
  • Unused imports removed
  • FSCT main configuration moved to specific configuration files (config.ini)
  • Dockerized code with entrypoint to invoke executions from host

@SKrisanski

SKrisanski commented Jun 4, 2022

Copy link
Copy Markdown
Owner

This looks great! Apologies for the slow reply. Thank you for your contribution. I was thinking about dockerising it myself only a few weeks ago.
I just need to do some testing myself before merging, but I'll aim to do that within a few weeks.
Thanks again,
Sean

@semocodev

Copy link
Copy Markdown
Author

Hi @SKrisanski. Maybe this PR is very large, i noticed.
I think could make piece of code more smaller.

@SKrisanski

Copy link
Copy Markdown
Owner

Hi Sergio,

Sorry I haven't got to it yet. No need to make it smaller, I'm just a bit short on time currently (I've been away from home for the last few weeks for work), so haven't had time to go through it thoroughly yet.

Thanks again for the PR.
I'll try to go through it soon.
Sean

@tariqislam

Copy link
Copy Markdown

Hi @SKrisanski ,

Any updates on the possibility of merging the dockerization changes to master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants